Refactor model and root handling #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
changed the title
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
==========================================
- Coverage 89.12% 88.81% -0.32%
==========================================
Files 34 34
Lines 5436 5336 -100
==========================================
- Hits 4845 4739 -106
- Misses 591 597 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to minimize the amount of nesting widgets and panes use, i.e. objects that can be updated inplace do not need to be nested inside a container. Only objects where the bokeh model is not well defined and therefore may need to be replaced entirely need to be nested.
This makes testing simpler, makes the bokeh model structure match the panel structure more closely and makes things easier for bokeh's layouts.